Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-3025 [SEARCH] Search result list auto refresh when perform some actions read/star/... #3187

Conversation

dab246
Copy link
Member

@dab246 dab246 commented Oct 2, 2024

Issue

#3025

Resolved

  • Search result list auto refresh:
no-refresh-list.mov
  • Actions for selection list incorrectly:
correctly-action.mov

@dab246 dab246 changed the title TF-3025 Search result list auto refresh when perform some actions read/start/... TF-3025 Search result list auto refresh when perform some actions read/star/... Oct 2, 2024
Copy link

github-actions bot commented Oct 2, 2024

This PR has been deployed to https://linagora.github.io/tmail-flutter/3187.

@dab246 dab246 added the search label Oct 2, 2024
@chibenwa
Copy link
Member

chibenwa commented Oct 3, 2024

If I do not search for unread emails then we do not need to update the search when the user reads a mail.

With the current implementation, would we refresh it?

@dab246
Copy link
Member Author

dab246 commented Oct 3, 2024

If I do not search for unread emails then we do not need to update the search when the user reads a mail.

With the current implementation, would we refresh it?

Yes, we will still refresh it. Please see below demo:

Screen.Recording.2024-10-03.at.14.54.24.mov

@chibenwa
Copy link
Member

chibenwa commented Oct 3, 2024

Yes, we will still refresh it.

Ok so by doing this we just x10 the count of search requests to the server, correct?

@dab246
Copy link
Member Author

dab246 commented Oct 3, 2024

Yes, we will still refresh it.

Ok so by doing this we just x10 the count of search requests to the server, correct?

No, I think I misunderstood you.

  1. If email is unread
WHEN user open this email or click `blue dot` icon 
THEN refresh email list & email mark as read
  1. If email is read
WHEN user open this email
THEN not refresh email list

@dab246 dab246 changed the title TF-3025 Search result list auto refresh when perform some actions read/star/... TF-3025 [SEARCH] Search result list auto refresh when perform some actions read/star/... Oct 7, 2024
@hoangdat
Copy link
Member

hoangdat commented Oct 9, 2024

  • when app has realtime update, search result also reload. We should not reload it
Screen.Recording.2024-10-09.at.09.13.38.mov

@dab246 dab246 changed the base branch from master to search-improvement-sprint-28 October 9, 2024 02:42
@dab246 dab246 force-pushed the bugfix/tf-3025-search-result-list-auto-refresh-when-perform-some-actions branch from ac89097 to 05fd187 Compare October 9, 2024 03:38
@dab246
Copy link
Member Author

dab246 commented Oct 9, 2024

  • when app has realtime update, search result also reload. We should not reload it

Screen.Recording.2024-10-09.at.09.13.38.mov

It still persists the list when real time update. Please check again. @hoangdat

Screen.Recording.2024-10-09.at.10.36.23.online-video-cutter.com.mp4

@hoangdat
Copy link
Member

hoangdat commented Oct 11, 2024

Please test mobile UI too

  • selection appbar in search result is not display well
    IMG_6435

@dab246
Copy link
Member Author

dab246 commented Oct 14, 2024

Please test mobile UI too

  • selection appbar in search result is not display well
    IMG_6435

Fixed.

Screenshot_20241014_093405

…rming some action `read/start/...` on each element
@dab246 dab246 force-pushed the bugfix/tf-3025-search-result-list-auto-refresh-when-perform-some-actions branch from 2985035 to c367d29 Compare October 14, 2024 04:48
@hoangdat hoangdat merged commit c549397 into search-improvement-sprint-28 Oct 14, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants